Replacing log15 by go-kit/log #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Switched logging from log15 to go-kit/log with logging level -- Switched from a global logger to a passed & shared one -- Using contextualized logging instead of repeating the "clientId" - Removed capitalized errors
- Switched logging from log15 to go-kit/log with logging level -- Switched from a global logger to a passed & shared one -- Using contextualized logging instead of repeating the "clientId" - Removed capitalized errors
mgenov
approved these changes
Oct 8, 2017
server/server.go
Outdated
| } | ||
|
|
||
| log15.Info("Starting...") | ||
| level.Info(server.Logger).Log("msg", "Starting...", "action", "ftp.starting") |
There was a problem hiding this comment.
As "msg" is duplicated on several places it could be extracted as package level constant. It won't remove the duplication actually, but will decouple name from code.
There was a problem hiding this comment.
Yep, that's true. It doesn't make it smaller / more manageable but easier to track and manage in an IDE. That's worth trying anyway.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clientId