Skip to content

Conversation

@drakkan
Copy link
Collaborator

@drakkan drakkan commented Dec 17, 2020

Server STAT should be improved from RFC 959

STATUS (STAT)

            This command shall cause a status response to be sent over
            the control connection in the form of a reply.  The command
            may be sent during a file transfer (along with the Telnet IP
            and Synch signals--see the Section on FTP Commands) in which
            case the server will respond with the status of the
            operation in progress, or it may be sent between file
            transfers.  In the latter case, the command may have an
            argument field.  If the argument is a pathname, the command
            is analogous to the "list" command except that data shall be
            transferred over the control connection.  If a partial
            pathname is given, the server may respond with a list of
            file names or attributes associated with that specification.
            If no argument is given, the server should return general
            status information about the server FTP process.  This
            should include current values of all transfer parameters and
            the status of connections.

we can at least disable it for now, thank you

@codecov
Copy link

codecov bot commented Dec 17, 2020

Codecov Report

Merging #204 (49bf434) into master (695e05f) will increase coverage by 0.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #204      +/-   ##
==========================================
+ Coverage   73.39%   73.54%   +0.14%     
==========================================
  Files           9        9              
  Lines        1060     1066       +6     
==========================================
+ Hits          778      784       +6     
  Misses        202      202              
  Partials       80       80              
Impacted Files Coverage Δ
handle_misc.go 95.77% <100.00%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 695e05f...49bf434. Read the comment docs.

Copy link
Owner

@fclairamb fclairamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not.

About how to fix that... If we take each possible uses of the command:

  1. "During a file transfer": Same as an ABOR, it requires a refactoring of the file handling logic right?
  2. "If the argument is a pathname": This is supported
  3. "If a partial pathname is given": It is contradicted by RFC3659 on wildcards. And I'm definitely not a fan of adding a wildcarding logic.
  4. "If no argument is given": This is correctly handled IMO

So... It looks like the only subject we should really handle is the first one. Am I missing something?

@probot-auto-merge probot-auto-merge bot merged commit 6678256 into fclairamb:master Dec 18, 2020
@drakkan
Copy link
Collaborator Author

drakkan commented Dec 18, 2020

Why not.

About how to fix that... If we take each possible uses of the command:

  1. "During a file transfer": Same as an ABOR, it requires a refactoring of the file handling logic right?
  2. "If the argument is a pathname": This is supported
  3. "If a partial pathname is given": It is contradicted by RFC3659 on wildcards. And I'm definitely not a fan of adding a wildcarding logic.
  4. "If no argument is given": This is correctly handled IMO

So... It looks like the only subject we should really handle is the first one. Am I missing something?

Correct. I don't plan to work on this, in SFTPGo I have a REST API that allows to get connection details.

@drakkan drakkan deleted the settings branch February 3, 2021 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants