Skip to content

Conversation

@drakkan
Copy link
Collaborator

@drakkan drakkan commented Dec 12, 2020

STAT should return 212 for directories and 213 for files

STAT should return 212 for directories and 213 for files
@codecov
Copy link

codecov bot commented Dec 12, 2020

Codecov Report

Merging #195 (518224f) into master (aed438b) will increase coverage by 2.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #195      +/-   ##
==========================================
+ Coverage   60.85%   62.97%   +2.12%     
==========================================
  Files           9        9              
  Lines         866      867       +1     
==========================================
+ Hits          527      546      +19     
+ Misses        267      246      -21     
- Partials       72       75       +3     
Impacted Files Coverage Δ
handle_files.go 58.01% <100.00%> (+8.25%) ⬆️
handle_misc.go 83.51% <0.00%> (+1.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aed438b...518224f. Read the comment docs.

@drakkan
Copy link
Collaborator Author

drakkan commented Dec 12, 2020

For directories pure-ftpd/proftpd also add "." and ".." to the response, for example:

STAT emptydir
212-Stato di emptydir:
 drwxr-xr-x   2 nicola   nicola       4096 Dec 12 11:13 .
 drwx------ 130 nicola   nicola      12288 Dec 12 16:36 ..
212 Fine dello stato
STAT /
212-Stato di /:
 drwxr-xr-x  17 root     root         4096 Sep 25 16:26 .
 drwxr-xr-x  17 root     root         4096 Sep 25 16:26 ..
 lrwxrwxrwx   1 root     root            7 Sep  2 22:30 bin -> usr/bin
 drwxr-xr-x   4 root     root         4096 Dec 10 07:13 boot
 drwxr-xr-x  22 root     root         3600 Dec 12 07:41 dev
....

the specs are not clear enough for me regarding this, should we add . and .. too? What do you think about? Thank you!

@drakkan
Copy link
Collaborator Author

drakkan commented Dec 14, 2020

I think we don't need to add . and .. many servers out of there don't include them, so the current behaviour seems fine

Copy link
Owner

@fclairamb fclairamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect

@fclairamb fclairamb merged commit aef0223 into fclairamb:master Dec 16, 2020
@drakkan drakkan deleted the stat branch February 3, 2021 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants