Skip to content

add support for multi-line replies #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 29, 2020
Merged

add support for multi-line replies #160

merged 1 commit into from
Jul 29, 2020

Conversation

@drakkan
Copy link
Collaborator

@drakkan drakkan commented Jul 26, 2020

This allows, for example, to send an initial multi-line banner

fclairamb
fclairamb approved these changes Jul 29, 2020
View reviewed changes
Copy link
Owner

@fclairamb fclairamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great !

@probot-auto-merge probot-auto-merge bot merged commit db03ff4 into fclairamb:master Jul 29, 2020
@drakkan
Copy link
Collaborator Author

drakkan commented Jul 29, 2020

Thank you for merging, I noticed there is also this method to write multiline answers, maybe we could replace this too.

I fixed #159 locally, I'll send this patch later today. I have no more blockers to add FTP support to SFTPGo, thank you for this library

@drakkan drakkan deleted the multiline_resp branch February 15, 2021 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fclairamb fclairamb fclairamb approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@drakkan @fclairamb