transfer open: add error checking #149
Merged
+29
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
send StatusFileStatusOK only if transfer.Open() returns no error. If an error happen send a 425 error code. This patch fixes the following use case: 1) start the ftpserver as non root user 2) start an active connection 3) request file list if the server is not started as root and ActiveTransferPortNon20 is not set then the server cannot bind to port 20. Before the patch this response is sent anyway: c.writeMessage(StatusFileStatusOK, "Using transfer connection") and the client hangs forever. After this patch the ftp client receive this error: ftp> ls 200 PORT command successful 425 Unable to open transfer: could not establish active connection due: dial tcp :20->127.0.0.1:37811: bind: permission denied tested using ftp CLI on Linux
if TransferOpen fails we already sent an error to the client, even before my previous commit. In handle dirs we don't send an error if TransferOpen fails, in handle files we could send an error instead, so check the error type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
send
StatusFileStatusOKonly iftransfer.Open()returns no error.If an error happen send a 425 error code.
This patch fixes the following use case:
if the server is not started as root and
ActiveTransferPortNon20is not set then the server cannot bind to port 20.Before the patch this response is sent anyway:
and the client hangs forever.
After this patch the ftp client receive this error:
tested using ftp CLI on Linux