Skip to content

Fix install-linter and and check-linter-version make targets #758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 17, 2025
Merged

Fix install-linter and and check-linter-version make targets #758

merged 1 commit into from
Sep 17, 2025

Conversation

philippschulte
Copy link
Member

Change summary

This PR fixes the install-linter and and check-linter-version make targets. golangci-lint is now downloaded via go install which makes the code much cleaner!

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

@philippschulte philippschulte requested a review from a team as a code owner September 17, 2025 16:19
@philippschulte philippschulte added the Skip-Changelog Do not check for changelog diff label Sep 17, 2025
@philippschulte
Copy link
Member Author 

philipp@philipp-XPS-15-9500:~/src/fastly/go-fastly$ make all
==> Downloading Go module
==> Tidying module
==> Installing golangci-lint v2.4.0
==> Running golangci-lint fmt
==> Checking golangci-lint version
==> Running golangci-lint
0 issues.

@philippschulte philippschulte merged commit 067d92a into fastly:main Sep 17, 2025
9 checks passed
@philippschulte philippschulte deleted the pschulte/fix-link-to-download-golangci-lint branch September 17, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthony-gomez-fastly anthony-gomez-fastly anthony-gomez-fastly approved these changes

Assignees
No one assigned
Labels
Skip-Changelog Do not check for changelog diff
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philippschulte @anthony-gomez-fastly