Skip to content

Update linter setup in CI and locally #757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 17, 2025
Merged

Update linter setup in CI and locally #757

merged 2 commits into from
Sep 17, 2025

Conversation

philippschulte
Copy link
Member

@philippschulte philippschulte commented Sep 17, 2025 •
edited
Loading

Change summary

This PR adds a second golangci-lint job (lint-latest (informational)) that runs with the latest version of the linter. This job is non-blocking (continue-on-error: true) and will not fail future PRs.

This PR also ensures consistent linting locally :

  • Pinning golangci-lint to version v2.4.0.
  • Downloading it to a local ./bin directory for use in make lint and make fmt.
  • Supporting cross-platform (Linux + macOS) detection for correct binary download.

Added the following targets to the Makefile:

  • install-linter: installs the correct linter version locally.
  • check-linter-version: ensures the expected version is being used.
  • clean-bin: removes the local ./bin directory if needed.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

@philippschulte philippschulte requested a review from a team as a code owner September 17, 2025 13:33
@philippschulte philippschulte added the Skip-Changelog Do not check for changelog diff label Sep 17, 2025
@rcaril
Copy link
Contributor

rcaril commented Sep 17, 2025

No concerns from my side.

@philippschulte philippschulte merged commit 7190c20 into fastly:main Sep 17, 2025
9 checks passed
@philippschulte philippschulte mentioned this pull request Sep 17, 2025
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpfleming kpfleming kpfleming approved these changes

@rcaril rcaril rcaril approved these changes

@anthony-gomez-fastly anthony-gomez-fastly anthony-gomez-fastly approved these changes

Assignees
No one assigned
Labels
Skip-Changelog Do not check for changelog diff
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@philippschulte @rcaril @kpfleming @anthony-gomez-fastly