breaking(ngwaf/rules): add support for the multival condition type #755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly into ngwaf-multival-conditions
Common package linting error is something that Philip is working on.
rcaril
changed the title
|
Also looping in @kpfleming to review as this will be a breaking change now. |
anthony-gomez-fastly
approved these changes
Sep 15, 2025
kpfleming
approved these changes
Sep 16, 2025
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change summary
This PR introduces support for the
multivalcondition type for NGWAF rules.New Feature Submissions:
Changes to Core Features:
Are there any considerations that need to be addressed for release?
New structs were created for multival to ensure Go comments were accurate.
Tests: