Skip to content

Conversation

simoneb
Copy link
Collaborator

@simoneb simoneb commented Feb 7, 2024

Fixes #539. Basically there were issues:

  • output was never proxied to the consuming workflow
  • we introduced a new status for auto-merge, a case not covered before

Checklist

@simoneb simoneb force-pushed the merge-status-output branch from 4bc164b to 1eb63b6 Compare February 7, 2024 12:04
@simoneb simoneb force-pushed the merge-status-output branch from 1eb63b6 to 896797a Compare February 7, 2024 12:05
@simoneb simoneb changed the title chore: test out merge status output fix: merge status output not working Feb 7, 2024
@simoneb simoneb marked this pull request as ready for review February 7, 2024 12:06
* Fixes dependabot/output-doesnot-seem-to-appear#539

* #539 adding random merge status key to verify

* #539 adding random merge status keys

* #539 removed log messages. Added workflow id to workflow

* #539 added workflow id to action yaml

* #539 removed unneeded changes in action yaml file

* fix #539 added new merge status for auto merge
@simoneb
Copy link
Collaborator Author

simoneb commented Feb 8, 2024

@climba03003 @Fdawgs could use a review here please

@simoneb simoneb requested a review from Eomm February 8, 2024 22:25
Copy link
Member

@Eomm Eomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after resolving conflicts

action.yml Outdated
skip-verification : ${{ inputs.skip-verification }}
- name: Merge/approve PR
uses: actions/github-script@v7
id: main
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
id: main
id: approver

action.yml Outdated
outputs:
merge_status:
description: "Merge status"
value: ${{ steps.main.outputs.merge_status }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
value: ${{ steps.main.outputs.merge_status }}
value: ${{ steps.approver.outputs.merge_status }}

@simoneb simoneb merged commit 0d14644 into main Feb 9, 2024
@simoneb simoneb deleted the merge-status-output branch February 9, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Output does not seem to appear

3 participants