Skip to content

This library should not depend DOM types #142

@khokm

Description

@khokm

Prerequisites

  • I have written a descriptive issue title
  • I have searched existing issues to ensure the bug has not already been reported

Fastify version

4

Plugin version

No response

Node.js version

20

Operating system

Windows

Operating system version (i.e. 20.04, 11.3, 10)

10

Description

This library depends on DOM types, which was introduced by #59.
The dom types was included to support this property:

domNode?: HTMLElement | null | undefined;

I don't see a reason why should domNode accept an HTMLElement interface in first place, because there there is nothing in Nodejs that implements this interface.

Can we remove domNode property, or replace it with unknown/any type at least? any type would be the best, because it makes it compatible with current code, so there is no need to bump major version.

Link to code that reproduces the bug

No response

Expected Behavior

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions