Skip to content

test: test for access-control-request-headers scenario (#77) #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 1, 2020

Conversation

alemagio
Copy link
Contributor

@alemagio alemagio commented Aug 1, 2020

Checklist

  • run npm run test and npm run benchmark
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message and code follows Code of conduct

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina
Copy link
Member

mcollina commented Aug 1, 2020

Is this done or are you adding more tests in this PR?

@alemagio
Copy link
Contributor Author

alemagio commented Aug 1, 2020

No.
If it's not a problem I will open more PRs in the future for this issue.

@mcollina mcollina merged commit a479093 into fastify:master Aug 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants