build(deps): replace mnemonist with toad-cache #366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jean-michelet
approved these changes
Mar 24, 2025
kibertoad
reviewed
Mar 24, 2025
vary.js
Outdated
| @@ -1,6 +1,6 @@ | |||
| 'use strict' | |||
|
|
|||
| const LRUCache = require('mnemonist/lru-cache') | |||
| const { Lru: LRUCache } = require('toad-cache') | |||
There was a problem hiding this comment.
wonder if we can get away with fifo. do we ever expect and overflow here or cache is big enough?
There was a problem hiding this comment.
I'm down to changing it, LRU is not critical here imo like in a rate limiter
There was a problem hiding this comment.
Updated in ebdaa0a. Have also changed it to be a map as per kibertoad/toad-cache#40
gurgunday
reviewed
Mar 24, 2025
Co-authored-by: Gürgün Dayıoğlu <[email protected]> Signed-off-by: Frazer Smith <[email protected]>
gurgunday
approved these changes
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every other Fastify repo that has an lru cache uses
toad-cache, so it makes sense to move this over so they used a shared dependency, reducing the size of node_modules by teeny amount.Checklist
npm run testandnpm run benchmarkand the Code of conduct