Skip to content

feat: support configuring CORS asynchronously #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 25, 2021
Merged

feat: support configuring CORS asynchronously #107

merged 1 commit into from
Jan 25, 2021

Conversation

Sikora00
Copy link
Contributor

Closes #106

Checklist

mcollina
mcollina reviewed Jan 23, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! Nice refactoring on all the helper methods.

@MaciejSikorski MaciejSikorski force-pushed the master branch 3 times, most recently from 050ff11 to ed10052 Compare January 23, 2021 21:32
@Sikora00 Sikora00 requested review from mcollina and zekth January 23, 2021 21:32
mcollina
mcollina requested changes Jan 23, 2021
View reviewed changes
mcollina
mcollina approved these changes Jan 23, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, good work! Let's see if we can get some other reviews

jsumners
jsumners approved these changes Jan 24, 2021
View reviewed changes
Copy link
Member

@jsumners jsumners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not very familiar with the code in this module. But the tests pass, and I think the feature is quite useful

zekth
zekth requested changes Jan 24, 2021
View reviewed changes
Copy link
Member

@zekth zekth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work. Just missing the types and test of types for promised based implementation.

@Sikora00 Sikora00 requested a review from zekth January 24, 2021 11:43
@mcollina mcollina merged commit 030d561 into fastify:master Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@jsumners jsumners jsumners approved these changes

@zekth zekth zekth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Configuring CORS Asynchronously
5 participants
@Sikora00 @mcollina @jsumners @zekth @MaciejSikorski