-
-
Notifications
You must be signed in to change notification settings - Fork 786
🔥 Drop support for Python 3.7 #830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
18178cf
to
314f504
Compare
This comment was marked as outdated.
This comment was marked as outdated.
2e8fcdd
to
caf601e
Compare
This comment was marked as outdated.
This comment was marked as outdated.
CI tests pass. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the very thorough PR!
I'll have to ask @tiangolo what the term is he wants to drop Python 3.7 by.
Note - I'm also maintaining spaCy and there we just bumped the Typer pin to allow any v0.x. If Typer drops Python 3.7 which spaCy v3 still supports, we'll have to again restrict the upper bound for Typer there. And I can imagine spaCy not being the only repo that would run into this.
I think we'll want to drop 3.7 at some point, it's just a question of when :-)
This comment was marked as outdated.
This comment was marked as outdated.
@svlandeg, thanks for reviewing the PR and for sharing your thoughts. 👍 I understand the concern about avoiding breaking dependent libraries. Besides, I rechecked the |
Thanks @kinuax! I want to keep support for Python 3.7 for a while. It's currently not being a problem (yet) so I prefer to delay this a bit. I would also want to have some features and fixes in before dropping support, so that people stuck in 3.7 can benefit from them too. |
This comment was marked as outdated.
This comment was marked as outdated.
@tiangolo, all right, I understand, thanks for clarifying. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Merge conflicts are solved and tests are passing. Ready to be reviewed. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Latest merge conflicts are solved. |
Recent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All our other repos (asyncer
, fastapi
, sqlmodel
) have now also dropped support for Python 3.7, as has Click. So I think we should go ahead and merge this to avoid issues on other PRs.
@kinuax: thanks for your continued work on this! Much appreciated 🙏
📝 Docs preview for commit f91947a at: https://1e602f84.typertiangolo.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The time has come, let's do this! 🚀 🔥
I'm not marking it as a breaking change because package installers like pip
and any others wouldn't accidentally install an unsupported version, so even if we make new releases with things unsupported in previous versions of Python, those won't be installed in those versions because the installer checks for Python version compatibility.
CPython and click already dropped support for Python 3.7. I would propose to proceed accordingly here in order to benefit from:
3.7 occurrences are updated.
Literal
related branching is cleaned._typing
is updated and simplified. All local tests pass on 3.8-3.12 and Linux.Context: #828