Skip to content

Conversation

@ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Oct 29, 2024

Fixes #1416

Related to #3234

Blocked by #3223 and #3233


Fixes the pattern using the regex provided in the issue:

#1416 (comment)

Workaround until this PR is merged:

const zipCode = faker.helpers.fake('{{helpers.fromRegExp("[ABCEGHJ-NPRSTVXY][0-9][ABCEGHJ-NPRSTV-Z] [0-9][ABCEGHJ-NPRSTV-Z][0-9]")}}');

@ST-DDT ST-DDT added c: bug Something isn't working s: on hold Blocked by something or frozen to avoid conflicts p: 1-normal Nothing urgent c: locale Permutes locale definitions m: location Something is referring to the location module labels Oct 29, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone Oct 29, 2024
@ST-DDT ST-DDT self-assigned this Oct 29, 2024
@ST-DDT ST-DDT force-pushed the refactor/locale/en_CA/location/zipcode branch from 68518c7 to d57204d Compare October 29, 2024 22:01
@codecov
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.96%. Comparing base (b9930dc) to head (9fc5193).

Additional details and impacted files
@@                       Coverage Diff                       @@
##           refactor/location/zipCode/fake    #3235   +/-   ##
===============================================================
  Coverage                           99.96%   99.96%           
===============================================================
  Files                                2805     2805           
  Lines                              217143   217126   -17     
  Branches                              969      968    -1     
===============================================================
- Hits                               217066   217049   -17     
  Misses                                 77       77           
Files with missing lines Coverage Δ
src/locales/en_CA/location/postcode_pattern.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@ST-DDT ST-DDT changed the title refactor(location): deprecate zipCode format parameter refactor(locale): fix en_CA postcode patterns Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: bug Something isn't working c: locale Permutes locale definitions m: location Something is referring to the location module p: 1-normal Nothing urgent s: on hold Blocked by something or frozen to avoid conflicts

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Invalid zip/postal codes when using locale en_CA

1 participant