Fix: remove desktop from enums according to documentation #808
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Type of Change
Typescript bug fix
Description
According to the documentation, the
IDevicetype should not include'desktop'as a valid value. I've removed this property from theDeviceTypeobject in./src/enums/ua-parser-enums.jsand updated the corresponding TypeScript definition files.Test
All unit tests passed.
Impact
This change may affect users who were previously using
'desktop'as a device type value in their TypeScript code. However, since this value is not officially supported according to the documentation, these users were likely relying on incorrect type definitions. The update brings TypeScript definitions in line with the actual library behavior and documented specifications.Users who were incorrectly using
'desktop'will now get TypeScript errors, guiding them to use the officially supported device types instead.