Bitwise assignment operators + tests #72
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull adds the assignment operators for the bitwise operators open feature request, as well as my own take on the base operators.
Removed from the end of 13 various functions
GNL10
commented
Mar 19, 2023
| { | ||
| throw std::invalid_argument("Operator '~' is undefined on negative operand"); | ||
| } | ||
| else if(*this == 0) |
There was a problem hiding this comment.
This was a quick fix, but in reality when we want to do ~0, we need to know how many bits we are working with, since
~0x0000 = 0xFFFF or ~0x0 =0xF.
So it seems that we have an undefined behavior here. How should I proceed?
Maybe this should case should also yield an exception.
|
Closing for lack of response. |
|
@faheel hello, can you recheck this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses the code implemented here and added tests to it.