feat(client): proxy and ssl configuration support #142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eschmidtfds
reviewed
Oct 19, 2023
src/main/java/com/factset/sdk/utils/authentication/ConfidentialClient.java
Show resolved
Hide resolved
eschmidtfds
reviewed
Oct 19, 2023
mima0815
reviewed
Oct 20, 2023
src/main/java/com/factset/sdk/utils/authentication/ConfidentialClient.java
Outdated
Show resolved
Hide resolved
mima0815
reviewed
Oct 20, 2023
src/main/java/com/factset/sdk/utils/authentication/ConfidentialClient.java
Outdated
Show resolved
Hide resolved
mima0815
reviewed
Oct 20, 2023
src/main/java/com/factset/sdk/utils/authentication/ConfidentialClient.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Manually tested the Proxy and SSL support on Burp Suite and the client acts as expected sending the request to the proxy server in Burp Suite and successfully managing to do the SSL handshake. |
eschmidtfds
previously approved these changes
Oct 23, 2023
src/main/java/com/factset/sdk/utils/authentication/ConfidentialClient.java
Outdated
Show resolved
Hide resolved
src/main/java/com/factset/sdk/utils/authentication/ConfidentialClient.java
Show resolved
Hide resolved
granitdula
changed the title
granitdula
changed the title
eschmidtfds
reviewed
Oct 23, 2023
mima0815
reviewed
Oct 24, 2023
mima0815
reviewed
Oct 24, 2023
eschmidtfds
approved these changes
Oct 24, 2023
granitdula
added a commit
that referenced
this pull request
Oct 26, 2023
Description Release 1.1.0: - Updated dependencies to latest stable versions - org.json:json from 20230227 to 20231013 - important dependency update which fixes Sonatype security threat - Removed unused dependency chore(deps): removed unused package #144 - feat(client): proxy and ssl configuration support feat(client): proxy and ssl configuration support #142
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for configuring SSL and proxies in the Confidential Client class.