DataLoadMCAP: add support to mcap logTime #1037
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facontidavide
requested changes
Jan 24, 2025
Owner
facontidavide
left a comment
facontidavide
left a comment
There was a problem hiding this comment.
I believe that a Radio button is better than a checkbox, to make clearer to the user what the alternatives are.
Contributor
Author
|
Got it! |
lucabart97
force-pushed
the
main
branch
2 times, most recently
from
d8bf606 to
e10698e
Compare
The DataLoadMCAP plugin support only the publishTime of the mcap message. Add a radio button in the load dialog to select the logTime or publishTime. Signed-off-by: Luca Bartoli <[email protected]>
Jofkos
pushed a commit
to Jofkos/PlotJuggler
that referenced
this pull request
Jun 29, 2025
The DataLoadMCAP plugin support only the publishTime of the mcap message. Add a radio button in the load dialog to select the logTime or publishTime. Signed-off-by: Luca Bartoli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DataLoadMCAP plugin support only the publishTime of the mcap message. Add a radio button in the load dialog to select the logTime or publishTime.