Skip to content

Fix conflict (internal, external) for pre-commit and update SVG #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 19 commits into from
Closed

Fix conflict (internal, external) for pre-commit and update SVG #140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
258e662
update CI for pre-commit (#133)
namgyu-youn Apr 11, 2025
378b92d
reformat for pre-commit
namgyu-youn Apr 11, 2025
00b53f7
update trigger for pre-commit and remove empty line (#133)
namgyu-youn Apr 11, 2025
efe2983
Revert "reformat for pre-commit"
namgyu-youn Apr 12, 2025
50f53d7
add ruff ignore for resolving back-and-forth issue (#133)
namgyu-youn Apr 12, 2025
293eed0
update SVG for pre-commit
namgyu-youn Apr 14, 2025
14941a5
Update SVG for pre-commit
namgyu-youn Apr 14, 2025
8b5cb15
add --exit-zero for ruff format
namgyu-youn Apr 14, 2025
c4d93cb
Merge branch 'main' of https://github.com/facebookresearch/optimizers
namgyu-youn Apr 15, 2025
08bae60
Merge branch 'main' of https://github.com/namgyu-youn/optimizers
namgyu-youn Apr 15, 2025
af6dac5
Merge branch 'main' of https://github.com/namgyu-youn/optimizers
namgyu-youn Apr 15, 2025
46e3b8b
add double-check for pre-commit (#14)
namgyu-youn Apr 15, 2025
183bbe2
Update convention for pre-commit (#133)
namgyu-youn Apr 13, 2025
6b40778
Refactor invalid configs tests (#141)
tsunghsienlee Apr 14, 2025
8d3be23
Refactor `QREigendecompositionConfig` test
tsunghsienlee Apr 14, 2025
6d62f9b
Leverage PyTorch `parametrize` to simplify test (#139)
tsunghsienlee Apr 14, 2025
067cc16
add double-check for pre-commit (#14)
namgyu-youn Apr 15, 2025
9d9472a
Merge branch 'main' of https://github.com/namgyu-youn/optimizers
namgyu-youn Apr 15, 2025
7ea4780
remove --exit-zero : it only works in ruff check
namgyu-youn Apr 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/pre-commit.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,4 @@ jobs:
- name: Run pre-commit on all files
run: |
source .venv/bin/activate
pre-commit run --all-files
pre-commit run --all-files || pre-commit run --all-files
3 changes: 1 addition & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,7 @@
[![Python3.12](https://img.shields.io/badge/python-3.12-blue.svg)](https://www.python.org/downloads/)
![tests](https://github.com/facebookresearch/optimizers/actions/workflows/tests.yaml/badge.svg)
![gpu-tests](https://github.com/facebookresearch/optimizers/actions/workflows/gpu-tests.yaml/badge.svg)
![linting](https://github.com/facebookresearch/optimizers/actions/workflows/lint.yaml/badge.svg)
![formatting](https://github.com/facebookresearch/optimizers/actions/workflows/format.yaml/badge.svg)
![pre-commit](https://github.com/facebookresearch/optimizers/actions/workflows/pre-commit.yaml/badge.svg)
![type-checking](https://github.com/facebookresearch/optimizers/actions/workflows/type-check.yaml/badge.svg)
![examples](https://github.com/facebookresearch/optimizers/actions/workflows/examples.yaml/badge.svg)

Expand Down