This repository was archived by the owner on Jan 13, 2022. It is now read-only.
Fix relative entry paths #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This doesn't break anything in win32 👍 |
Author
|
@cpojer Could you make a release on npm for this, it was blocking updating node-haste in react-native. I'd to get the win32 fixes from the last version in the next release of RN to avoid having it broken for a whole release. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert this change (9673f86#diff-1fdf421c05c1140f6d71444ea2b27638L198) as it caused relative entry paths to not work properly and add a test for that regression. The issue happened in react-native it didn't resolve the app entry point properly. See facebook/react-native#6260 (comment) for more context.
Any reason why this was changed?
cc @cpojer @davidaurelio @yaycmyk