Disable 'comma-dangle' eslint rule for './addons' #9965
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**what is the change?:** Added an `eslintrc` which disables the 'comma-dangle' rule just for addons. **why make this change?:** To get CI passing again on the 15* branches. We don't have dangling commas in the addons because it breaks GCC under certain conditions. This doesn't affect React because we use Babel with React, but it's not worth setting up Babel for the addons at this time. **test plan:** `yarn lint` **issue:** None - hopefully will fix this before it's a problem
gaearon
approved these changes
Jun 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what is the change?:
Added an
eslintrcwhich disables the 'comma-dangle' rule just foraddons.
why make this change?:
To get CI passing again on the 15* branches.
We don't have dangling commas in the addons because it breaks GCC under
certain conditions. This doesn't affect React because we use Babel with
React, but it's not worth setting up Babel for the addons at this time.
test plan:
yarn lintissue:
None - hopefully will fix this before it's a problem