Add package builds for new server renderer and enable tests #9710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently this case is using the stack renderer.
In our tests this normally happens because ReactDOM.js injects them into the shared module, but when Fiber is enabled or this is its own flat bundle, that doesn't happen.
ReactServer -> ReactDOMServerStream This file is going to be the replacement for ReactDOMServer. I mock ReactDOMServer and user ReactDOMServerStream when we have the fiber flag enabled. I'm now also enabling this as the default for distributions builds (react-dom/server on npm and react-dom-server.production.min.js as umd bundle). I'm using traverseStackChildren instead of traverseAllChildren because traverseAllChildren is now only in the isomorphic package and we don't want to build all of that that into the server package. I also have to require lower case react for the builds to work.
sophiebits
approved these changes
May 18, 2017
| expectTextNode(e.childNodes[0], ''); | ||
| expectTextNode(e.childNodes[1], ''); | ||
| expectTextNode(e.childNodes[2], ''); | ||
| if (render === serverRender) { |
Collaborator
There was a problem hiding this comment.
I'm sure @aickin is thrilled to see this check.
Contributor
There was a problem hiding this comment.
Imagine a single tear streaming down my face... 😢
(but seriously: this PR is super, super, super exciting)
Collaborator
Author
There was a problem hiding this comment.
Once my other PR gets approved by reviewers I can start removing some of the differences (like comment tags). :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #9673
Rename ReactServer -> ReactDOMServerStream This file is going to be the replacement for ReactDOMServer.
I mock ReactDOMServer and user ReactDOMServerStream when we have the fiber flag enabled. I'm now also enabling this as the default for distributions builds (react-dom/server on npm and react-dom-server.production.min.js as umd bundle).
I'm using traverseStackChildren instead of traverseAllChildren because traverseAllChildren is now only in the isomorphic package and we don't want to build all of that that into the server package.
I also have to require lower case react for the builds to work.
I also pulled in two commits from #9580 which fixes ReactDOMServer in Fiber mode, which fixed tests we're no longer testing (the injection) and fixes some assertions in Fiber mode to ensure that we pass a proper amount of tests.
Test Plan: Tested the SSR fixture.