Skip to content

Conversation

@abhaynikam
Copy link
Contributor

Before submitting a pull request, please make sure the following is done:

  1. Fork the repository and create your branch from master.
  2. If you've added code that should be tested, add tests!
  3. If you've changed APIs, update the documentation.
  4. Ensure the test suite passes (npm test).
  5. Make sure your code lints (npm run lint).
  6. Format your code with prettier (npm run prettier).
  7. Run the Flow typechecks (npm run flow).
  8. If you added or removed any tests, run ./scripts/fiber/record-tests before submitting the pull request, and commit the resulting changes.
  9. If you haven't already, complete the CLA.

@abhaynikam
Copy link
Contributor Author

Issue was related to #9421

@abhaynikam abhaynikam changed the title Updated installation doc for showing acitve tabs Updated installation doc for showing active tabs Apr 14, 2017
@gaearon
Copy link
Collaborator

gaearon commented Apr 18, 2017

Thanks, but I feel this makes it more complicated than it is now, and I’m not sure how valuable it is given that you can still click on the link to get its anchor. I’d like to keep this simple and probably update to using buttons instead. So I’ll keep it the way it is, but appreciate the effort.

@gaearon gaearon closed this Apr 18, 2017
@abhaynikam abhaynikam deleted the update-troubleshooting-docs branch April 18, 2017 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants