Updated link and text for beginner friendly in how-to-contribute #9280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaearon
requested changes
Apr 18, 2017
Collaborator
gaearon
left a comment
gaearon
left a comment
There was a problem hiding this comment.
Thanks for the PR! This changes a generated file so it wouldn't work. You need to change the .md file instead. Could you please do that instead?
Here is the file: https://github.com/facebook/react/blob/master/docs/contributing/how-to-contribute.md.
Collaborator
|
cc @acdlite, please make sure to update the docs if you change the labels 😉 . There's been a few PRs fixing this up in a few different places. |
Contributor
|
The source file was updated in #9429, so this change should be included the next time the docs are generated 👍 |
Collaborator
|
Ah okay, thanks! |
Contributor
Author
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I am trying to update the necessary links for
beginner friendly bugsingh-pages. cc: @acdlite