[Fiber] Throw on plain object children #8890
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acdlite
commented
Jan 30, 2017
| } = ReactTypeOfSideEffect; | ||
|
|
||
| const { | ||
| getComponentName, |
Collaborator
Author
There was a problem hiding this comment.
Only need this in DEV
sophiebits
approved these changes
Jan 31, 2017
| ' If you meant to render a collection of children, use an array ' + | ||
| 'instead or wrap the object using createFragment(object) from the ' + | ||
| 'React add-ons.'; | ||
| if (newChild._isReactElement) { |
Collaborator
There was a problem hiding this comment.
We don't need this check any more; it's legacy. You can delete it and the test if you want.
Same behavior as Stack
Won't work if the returnFiber is a fragment. Not sure it matters; warning will just be less descriptive.
Preserves Stack behavior. There's already a warning for this.
acdlite
force-pushed
the
fiberfragmentinvariants
branch
from
621337e to
2a0fb5b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a few mores tests.
Also uncovered an oversight in the reconciler related to portals; was missing a portal case in
updateSlot.