Skip to content

Conversation

@Jwan622
Copy link

@Jwan622 Jwan622 commented Jan 14, 2017

Fixing some code by closing a JSX tag.

Before submitting a pull request, please make sure the following is done...

  1. Fork the repo and create your branch from master.
  2. If you've added code that should be tested, add tests!
  3. If you've changed APIs, update the documentation.
  4. Ensure the test suite passes (npm test).
  5. Make sure your code lints (npm run lint) - we've done our best to make sure these rules match our internal linting guidelines.
  6. If you haven't already, complete the CLA.

Fixing some code
@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact [email protected] if you have any questions.

@gaearon
Copy link
Collaborator

gaearon commented Jan 14, 2017

This is intentional:

the opening tag returned in the render() function of the Square class to:

There is some content inside of it, it's in the CodePen if you follow the tutorial but not in the tutorial.

Thanks for PR though!

@gaearon gaearon closed this Jan 14, 2017
@aweary
Copy link
Contributor

aweary commented Jan 14, 2017

@gaearon we've had probably half a dozen PRs submitted to fix this, it might be a good idea to change this section to be clearer.

@gaearon
Copy link
Collaborator

gaearon commented May 1, 2017

@brigand and I rewrote some parts of the tutorial in #9454, and following along should be easier now. Let us know if you're still struggling! We’re happy to look at remaining issues in case we missed anything.

https://facebook.github.io/react/tutorial/tutorial.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants