Skip to content

Conversation

@DaleSeo
Copy link

@DaleSeo DaleSeo commented Oct 7, 2016

  • Translate the English text to Korean in CommentBox.
  • Improve translation about inserting raw HTML using remarkable.

I'm afraid this Korean translation causes readers to misunderstand that it's secure to insert raw HTML in any cases as long as they use remarkable.
I corrected it, so readers can be reminded that it might be still dangerous.
The English texts in both CommentList and CommentForm are translated.
However, the English text in Comment Box is not.
It would improve the consistency of this Korean tutorial.
@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@gaearon
Copy link
Collaborator

gaearon commented Oct 15, 2016

Hi! Thank you for the PR, but we already deleted this tutorial in the work-in-progress branch with new docs: #7864.

I will close this PR because the old content will be gone soon, and this would cause merge conflicts. Really apologize for this. We'll merge new docs soon, and then start a new localization effort.

@gaearon gaearon closed this Oct 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants