-
Notifications
You must be signed in to change notification settings - Fork 50.2k
Community tab #7854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Community tab #7854
Conversation
sophiebits
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you post a screenshot?
| $ bundle exec rake fetch_remotes | ||
| $ bundle exec jekyll serve -w | ||
| $ open http://localhost:4000/react/ | ||
| $ open http://localhost:4000/react/index.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can't actually go to localhost:4000/react, that 404s
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| permalink: support.html | ||
| title: Where To Get Support | ||
| layout: community | ||
| permalink: community/support.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moving this URL but none of the rest that are going into the section?
Should we just go ahead and rename files to fit now as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah good point I'll rename
|
Can you get the tab at top to light up properly like the others do? |
sophiebits
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
| $ bundle exec rake fetch_remotes | ||
| $ bundle exec jekyll serve -w | ||
| $ open http://localhost:4000/react/ | ||
| $ open http://localhost:4000/react/index.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
A couple of these pages are translated (even if not entirely up to date). Should we move those files as well since we moved the other files without change? It's not clear what the final state will be here - it might make sense to delete translations now but if we're going to keep what we have, even if just for now, we should move those files to stay alongside the English content. |
|
👍 squash & merge to your heart's content |


This changes the "support" tab into the "community" tab and moves the current "community resources" section there, along with keeping the original "support" page. We can change the content of the "community" stuff later, this PR is just handling the layout.