Skip to content

Conversation

@lacker
Copy link
Contributor

@lacker lacker commented Oct 3, 2016

This changes the "support" tab into the "community" tab and moves the current "community resources" section there, along with keeping the original "support" page. We can change the content of the "community" stuff later, this PR is just handling the layout.

Copy link
Collaborator

@sophiebits sophiebits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you post a screenshot?

$ bundle exec rake fetch_remotes
$ bundle exec jekyll serve -w
$ open http://localhost:4000/react/
$ open http://localhost:4000/react/index.html
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can't actually go to localhost:4000/react, that 404s

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me…

image

permalink: support.html
title: Where To Get Support
layout: community
permalink: community/support.html
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving this URL but none of the rest that are going into the section?

Should we just go ahead and rename files to fit now as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah good point I'll rename

@lacker
Copy link
Contributor Author

lacker commented Oct 3, 2016

screencapture-localhost-4000-react-community-support-html-1475527394177
Here's what the "community" tab looks like now. Basically the same as current "support" page but with the community stuff on the sidebar

@sophiebits
Copy link
Collaborator

Can you get the tab at top to light up properly like the others do?

@lacker
Copy link
Contributor Author

lacker commented Oct 3, 2016

OK - @spicyj the tab at the top now lights up appropriately, @zpao the files are named according to their URLs, any other feedback from folks?

Copy link
Collaborator

@sophiebits sophiebits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

$ bundle exec rake fetch_remotes
$ bundle exec jekyll serve -w
$ open http://localhost:4000/react/
$ open http://localhost:4000/react/index.html
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me…

image

@zpao
Copy link
Member

zpao commented Oct 3, 2016

A couple of these pages are translated (even if not entirely up to date). Should we move those files as well since we moved the other files without change? It's not clear what the final state will be here - it might make sense to delete translations now but if we're going to keep what we have, even if just for now, we should move those files to stay alongside the English content.

@lacker
Copy link
Contributor Author

lacker commented Oct 3, 2016

@zpao OK I moved the translations too.

@spicyj Ah I was actually doing /react which 404s, and /react/ works. If you don't mind let's keep it this way?

@zpao
Copy link
Member

zpao commented Oct 3, 2016

👍 squash & merge to your heart's content

@lacker lacker merged commit f7c9c40 into facebook:new-docs Oct 3, 2016
@lacker lacker deleted the community-tab branch October 3, 2016 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants