[docs] Use react-standalone #7668
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Member
|
Thanks! I've been meaning to update React to use babel-standalone in the examples. Thanks for working on it 😄 |
Daniel15
reviewed
Sep 26, 2016
| <script src="https://unpkg.com/react@{{site.react_version}}/dist/react.js"></script> | ||
| <script src="https://unpkg.com/react-dom@{{site.react_version}}/dist/react-dom.js"></script> | ||
| <script src="https://unpkg.com/babel-[email protected]/browser.min.js"></script> | ||
| <script src="https://unpkg.com/babel-[email protected]/babel.min.js"></script> |
Member
There was a problem hiding this comment.
Babel-standalone is on CDNJS and I've seen better perf with CDNJS compared to unpkg (also it has more users so it's more likely to hit the cache). Maybe use CDNJS instead?
Daniel15
reviewed
Sep 26, 2016
| <script src="bower_components/react/react.js"></script> | ||
| <script src="bower_components/react/react-dom.js"></script> | ||
| <script src="https://unpkg.com/babel-[email protected]/browser.min.js"></script> | ||
| <script src="https://unpkg.com/babel-[email protected]/babel.min.js"></script> |
Member
There was a problem hiding this comment.
In this one, you might want to use babel-standalone from Bower for consistency. Updating the install command to bower install --save react babel-standalone should work.
Member
|
Instead of using |
Contributor
|
Looks like this super out of date, and was addressed in #7868 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I missed that #5497 got closed and babel-standalone supports what I wanted, so we can do this now.