Skip to content

Remove dead HAS_SIDE_EFFECTS logic. #6987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jimfb merged 1 commit into from
Jun 22, 2016
Merged

Remove dead HAS_SIDE_EFFECTS logic. #6987

jimfb merged 1 commit into from
Jun 22, 2016

Conversation

@jimfb
Copy link
Contributor

@jimfb jimfb commented Jun 7, 2016 •
edited
Loading

Remove dead HAS_SIDE_EFFECTS logic. Fixes #6979.

@jimfb
Copy link
Contributor Author

jimfb commented Jun 8, 2016

cc @zpao

@jimfb
Copy link
Contributor Author

jimfb commented Jun 20, 2016

Ping @zpao

@zpao
Copy link
Member

zpao commented Jun 22, 2016

👍

@jimfb jimfb merged commit 416b5ef into facebook:master Jun 22, 2016
@zpao zpao added this to the 15-next milestone Jul 7, 2016
zpao pushed a commit that referenced this pull request Jul 8, 2016
@jimfb @zpao
Remove dead HAS_SIDE_EFFECTS logic (#6987)
8ea1ee1 
(cherry picked from commit 416b5ef)
@zpao zpao modified the milestones: 15-next, 15.2.1 Jul 8, 2016
@akre54 akre54 mentioned this pull request Jul 18, 2016
Closed
@jdalton jdalton mentioned this pull request Nov 10, 2016
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed

Projects

None yet

Milestone

15.2.1

Development

Successfully merging this pull request may close these issues.

2 participants

@jimfb @zpao