-
Notifications
You must be signed in to change notification settings - Fork 50.2k
[WIP] Streaming server renderer on top of existing client checksum validator #6836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
aickin
wants to merge
43
commits into
facebook:master
from
aickin:new-server-renderer-old-client-validator
Closed
Changes from all commits
Commits
Show all changes
43 commits
Select commit
Hold shift + click to select a range
a48b7b3
Interim checking with a bunch of unit tests for server rendering, and…
aickin 2fef93f
Fixed a bunch of tests up to run with warnings correctly.
aickin b4defa7
Converted two tests to use the itRenders framework. All tests passing.
aickin 3aedcb9
Moved a bunch of tests from the markup match/mismatch section to the …
aickin cca6d7d
Ported a few more tests to itRenders
aickin 2985e83
Found out that unit tests in this codebase automagically have access …
aickin bb705fb
Interim checkin of new renderer with the new unit tests but old valid…
aickin 9842aa9
Fixed a problem that was happening with server warning messages disab…
aickin 77b3b90
Fixed a bug where the tests were depending on the behavior that serve…
aickin 1eeaa6b
Oops, forgot to add ReactServerRenderingAsync to the codebase.
aickin de518d1
Fixed the remaining server rendering test failures. There are still s…
aickin 0a2b824
Removed ReactComponentTreeDevtool tests for server rendering.
aickin 41a0cb1
removed an error check that is now unnecessary
aickin edb8df4
Added Adler32 hash to streaming render, but no tests yet.
aickin 155d993
Added stream tests, though I can't test them against this branch.
aickin c0dcf9e
Merge branch 'added-unit-tests-with-stream' into new-server-renderer-…
aickin 53ddeda
Scripts don't run until you add them to the document. Fixed that.
aickin a06b221
Merge branch 'added-unit-tests-with-stream' into new-server-renderer-…
aickin dcd4139
Fixed some bugs in unit tests; still failing with stream tests that h…
aickin d2b032a
Added warning counts to the stream rendering functions.
aickin 8612827
Merge branch 'added-unit-tests-with-stream' into new-server-renderer-…
aickin 32e0c72
Share a little bit of logic with ReactDOMComponent, and remove some u…
aickin a929fa1
Small refactor to make propsToAttributes more understandable
aickin 8ed3f29
I missed changing one of the call sites in the last checkin.
aickin ffaea33
Made the internal class for async render act more like a generator. F…
aickin 586d625
Modified the streaming tests to catch errors thrown when render() is …
aickin 3f59d81
Merge branch 'added-unit-tests-with-stream' into new-server-renderer-…
aickin aa87896
Converted several tests to itRenders
aickin e0ff41c
Merge branch 'added-unit-tests' into added-unit-tests-with-stream
aickin b7291af
Merge branch 'added-unit-tests-with-stream' into new-server-renderer-…
aickin 50b65f2
Added a few tests for non-standard and custom elements.
aickin 7da5609
Merge branch 'added-unit-tests' into added-unit-tests-with-stream
aickin 79f70ba
Merge branch 'added-unit-tests-with-stream' into new-server-renderer-…
aickin b220514
Added support for attributes on custom elements in the new renderer; …
aickin 52a96dc
Fixing some lint problems
aickin 8e35f6c
Merge branch 'master' into added-unit-tests
aickin 37a88a6
Merge branch 'added-unit-tests' into added-unit-tests-with-stream
aickin 67d3494
Merge branch 'added-unit-tests-with-stream' into new-server-renderer-…
aickin cc42fb6
Fixed tests that were broken by the merge. Added support for debug to…
aickin 0f14e3e
Added some comments and renamed 'tree' to 'node' in the render code.
aickin fb63b3c
Fixed packaging issues and one runtime error.
aickin 5203d68
Two perf enhancements. One is to streamline html escaping for strings…
aickin 325fca4
Fixing some errors discovered when I tried to run the benchmark scrip…
aickin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -50,6 +50,7 @@ var babelOpts = { | |
| [babelPluginModules, { map: moduleMap }], | ||
| ], | ||
| }; | ||
| babelOpts.plugins[0][1].map.stream = 'stream'; | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I believe this line is needed to get require to look for a package rather than a module that uses providesModule. |
||
|
|
||
| gulp.task('react:clean', function() { | ||
| return del([paths.react.lib]); | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this incantation is necessary to stop browserify from bundling in a fake version of node's stream library.