Skip to content

Add JSDoc comment to keep license when compiling production code #6539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andykenward wants to merge 2 commits into from
Closed

Add JSDoc comment to keep license when compiling production code #6539

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c0cab8d
Added JSDoc comment for license and version
Apr 18, 2016
a4e7bf9
#6539 reduced comment to just @license and added to npm package of react
Apr 18, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion grunt/data/header-template-extended.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/**
* <%= package %> v<%= version %>
*
* @license
Copy link
Collaborator

@gaearon gaearon Jun 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let’s remove changes to this one file. Since we already have a header in the React module entry point, this causes license header to be outputted twice in the UMD build.

Copy link
Member

@zpao zpao Jun 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually think I want to keep this so it ends up consistently at the top of all dist files.

But then we would want to add it to the files in packages/react* so that npm-bundled files also have it.

Copy link
Collaborator

@gaearon gaearon Jun 22, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It wouldn’t be super nice if every react addon added one, would it?

Copy link
Member

@zpao zpao Jun 22, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meh, it'll future proof for when those aren't a part of the react package.

* Copyright 2013-present, Facebook, Inc.
* All rights reserved.
*
Expand Down
1 change: 1 addition & 0 deletions src/isomorphic/React.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
/**
* @license
* Copyright 2013-present, Facebook, Inc.
* All rights reserved.
*
Expand Down