Skip to content

Fix .value test to be consistent in HTML mode #6427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sophiebits wants to merge 1 commit into from
Closed

Fix .value test to be consistent in HTML mode #6427

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/renderers/dom/shared/__tests__/ReactDOMComponent-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -493,6 +493,7 @@ describe('ReactDOMComponent', function() {
return nodeValue;
},
set: nodeValueSetter.mockImplementation(function(newValue) {
node.setAttribute('value', newValue);
Copy link
Member

@zpao zpao Apr 6, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Said offline but the DOM doesn't do this so while it tricks the test it's not real life.

nodeValue = newValue;
}),
});
Expand All @@ -506,17 +507,18 @@ describe('ReactDOMComponent', function() {
ReactDOM.render(<div value="foo" />, container);
expect(nodeValueSetter.mock.calls.length).toBe(1);

// Really, this _should_ remove the attribute but doesn't currently.
ReactDOM.render(<div />, container);
expect(nodeValueSetter.mock.calls.length).toBe(2);

ReactDOM.render(<div value={null} />, container);
expect(nodeValueSetter.mock.calls.length).toBe(2);

ReactDOM.render(<div value="" />, container);
expect(nodeValueSetter.mock.calls.length).toBe(3);
expect(nodeValueSetter.mock.calls.length).toBe(2);

ReactDOM.render(<div />, container);
expect(nodeValueSetter.mock.calls.length).toBe(3);
expect(nodeValueSetter.mock.calls.length).toBe(2);
});

it('should not incur unnecessary DOM mutations for boolean properties', function() {
Expand Down