Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 21 additions & 2 deletions src/renderers/dom/client/eventPlugins/SimpleEventPlugin.js
Original file line number Diff line number Diff line change
Expand Up @@ -487,7 +487,7 @@ var SimpleEventPlugin = {

eventTypes: eventTypes,

extractEvents: function(
extractEventConstructor: function(
topLevelType,
targetInst,
nativeEvent,
Expand Down Expand Up @@ -604,8 +604,27 @@ var SimpleEventPlugin = {
'SimpleEventPlugin: Unhandled event type, `%s`.',
topLevelType
);
return EventConstructor;
},

extractEvents: function(
topLevelType,
targetInst,
nativeEvent,
nativeEventTarget
) {
var EventConstructor = SimpleEventPlugin.extractEventConstructor(
topLevelType,
targetInst,
nativeEvent,
nativeEventTarget
);
if (!EventConstructor) {
return null;
}

var event = EventConstructor.getPooled(
dispatchConfig,
topLevelEventsToDispatchConfig[topLevelType],
targetInst,
nativeEvent,
nativeEventTarget
Expand Down
28 changes: 22 additions & 6 deletions src/test/ReactTestUtils.js
Original file line number Diff line number Diff line change
Expand Up @@ -472,6 +472,12 @@ ReactShallowRenderer.prototype._render = function(element, transaction, context)
* - ... (All keys from event plugin `eventTypes` objects)
*/
function makeSimulator(eventType) {
var dispatchConfig = EventPluginRegistry.eventNameDispatchConfigs[eventType];
// Get the topLevelType so we can extract the right SyntheticEvent type so we
// copy properties correctly from the native event and also get our warnings
// related to pooling.
var topLevelType = EventConstants.topLevelTypes[dispatchConfig.dependencies[0]];

return function(domComponentOrNode, eventData) {
var node;
invariant(
Expand All @@ -485,20 +491,30 @@ function makeSimulator(eventType) {
node = domComponentOrNode;
}

var dispatchConfig =
EventPluginRegistry.eventNameDispatchConfigs[eventType];
var EventPlugin = EventPluginRegistry.getPluginModuleForEvent({dispatchConfig});

// Assign the extra event data to the native event, ensuring we copy they
// correct data over for a given event. Other fields will be dropped.
var fakeNativeEvent = new Event();
fakeNativeEvent.target = node;
Object.assign(fakeNativeEvent, {target: node}, eventData);

var inst = ReactDOMComponentTree.getInstanceFromNode(node);

var SyntheticEventConstructor = EventPlugin.extractEventConstructor(
topLevelType,
domComponentOrNode,
fakeNativeEvent,
node
);

// We don't use SyntheticEvent.getPooled in order to not have to worry about
// properly destroying any properties assigned from `eventData` upon release
var event = new SyntheticEvent(
var event = new SyntheticEventConstructor(
dispatchConfig,
ReactDOMComponentTree.getInstanceFromNode(node),
domComponentOrNode,
fakeNativeEvent,
node
);
Object.assign(event, eventData);

if (dispatchConfig.phasedRegistrationNames) {
EventPropagators.accumulateTwoPhaseDispatches(event);
Expand Down
23 changes: 23 additions & 0 deletions src/test/__tests__/ReactTestUtils-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -474,6 +474,29 @@ describe('ReactTestUtils', function() {
expect(handler).not.toHaveBeenCalled();
});

it('should not warn when simulating events with extra properties', function() {
spyOn(console, 'error');

var CLIENT_X = 100;

var Component = React.createClass({
handleClick: function(e) {
expect(e.clientX).toBe(CLIENT_X);
},
render: function() {
return <div onClick={this.handleClick} />;
},
});

var element = document.createElement('div');
var instance = ReactDOM.render(<Component />, element);
ReactTestUtils.Simulate.click(
ReactDOM.findDOMNode(instance),
{clientX: CLIENT_X}
);
expect(console.error.calls.length).toBe(0);
});

it('can scry with stateless components involved', function() {
var Stateless = () => <div><hr /></div>;
var SomeComponent = React.createClass({
Expand Down