Change tabIndex to MUST_USE_ATTRIBUTE to avoid special focus treatment in Chrome #5907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t in Chrome Chrome treats anchor tags with an explicit `tabIndex='0'` different then if the attribute was not present. Specifically when clicking a link with an implicit tab index (i.e. no attribute on the node) no focus outline is shown. Whereas with an explicit tabindex='0' it does get shown. This is super minor, but maintaining react-bootstrap has taught me that A LOT of people are VERY touchy about browsers focus outlines. If anything this just makes the behavior consistent across browsers. (tested in recent FF, Chrome, and Edge) example: https://jsfiddle.net/7kmck1f7/1/
Contributor
|
@jquense updated the pull request. |
Contributor
|
I suspect this was fixed in #1510 At the very least, this will no longer pass tests if you rebase. |
Contributor
|
@jquense Can you verify that the problem was fixed in master? |
Contributor
Author
|
🎉 confirmed that the PR fixed it! thanks :) This is great change! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chrome treats anchor tags with an explicit
tabIndex='0'different then if the attribute was not present. Specifically when clicking a link with an implicit tab index (i.e. no attribute on the node) no focus outline is shown. Whereas with an explicit tabindex='0' it does get shown. This is super minor, but maintaining react-bootstrap has taught me that A LOT of people are VERY touchy about browser focus outlines.If anything this just makes the behavior consistent across browsers. (tested in recent FF, Chrome, and Edge)
example: https://jsfiddle.net/7kmck1f7/1/