Allow setting defaultValue as a property for #4618
#5666
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #4618, which allows updates to
defaultValueon uncontrolled<input>s. Browsers will reflect changes todefaultValueunless the user has changed the input value. This patch also allows updates todefaultValueon a controlled element withvalue == null.@spicyj suggested using
setAttribute('value'), but instead this patch sets thedefaultValueproperty as a property. The goal is to keep behavior as consistent with current day as possible.If we like this approach, we should consider bringing it to
<textarea>and<select>, as well.Here's a simple test of the patch on JSBin: https://jsbin.com/yagasi/edit?js,output