Skip to content

Fix: Guard against re-entry in Scheduler (Issue #17355) #35437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
biplavbarua wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −0
Open

Fix: Guard against re-entry in Scheduler (Issue #17355) #35437

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions packages/scheduler/src/forks/Scheduler.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -500,6 +500,14 @@ const performWorkUntilDeadline = () => {
// remain true, and we'll continue the work loop.
let hasMoreWork = true;
try {
if (isPerformingWork) {
// A scheduled task triggered a host event (e.g. valid re-entry).
// If we process it now, we'll lose key context. Schedulers that
// support re-entry should verify that the queue is empty before
// processing.
// For now, we'll just yield.
return;
}
hasMoreWork = flushWork(currentTime);
} finally {
if (hasMoreWork) {
Expand Down