Skip to content

[DevTools] Filter out built-in stack frames #34828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sebmarkbage merged 1 commit into from
Oct 14, 2025
Merged

[DevTools] Filter out built-in stack frames #34828

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions packages/react-devtools-shared/src/devtools/views/Components/StackTraceView.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,17 @@
padding: 0.25rem;
}

.CallSite, .IgnoredCallSite {
.CallSite {
display: block;
padding-left: 1rem;
}

.IgnoredCallSite {
opacity: 0.5;
.IgnoredCallSite, .BuiltInCallSite {
display: none;
}

.CallSite + .BuiltInCallSite {
display: block;
}
Comment on lines +14 to 16
Copy link
Collaborator

@eps1lon eps1lon Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't handle the double-whopper pattern but that's quite rare 😆

Copy link
Collaborator Author

@sebmarkbage sebmarkbage Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that the Chrome built in also doesn’t handle that because they use a similar selector.

However they do it in reverse and hide it only if it’s behind a hidden. The problem with that is that it doesn’t handle when the last frame is a built in. Which maybe should be shown if that’s where the error happened.

But for us it’s likely that the last frame is a built in only because the actual ones were filtered on the server and we don’t know that.


.Link {
Expand Down
22 changes: 14 additions & 8 deletions packages/react-devtools-shared/src/devtools/views/Components/StackTraceView.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,16 +60,22 @@ export function CallSiteView({
symbolicatedCallSite !== null ? symbolicatedCallSite.location : callSite;
const ignored =
symbolicatedCallSite !== null ? symbolicatedCallSite.ignored : false;
if (ignored) {
// TODO: Make an option to be able to toggle the display of ignore listed rows.
// Ideally this UI should be higher than a single Stack Trace so that there's not
// multiple buttons in a single inspection taking up space.
return null;
}
// TODO: Make an option to be able to toggle the display of ignore listed rows.
// Ideally this UI should be higher than a single Stack Trace so that there's not
// multiple buttons in a single inspection taking up space.

const isBuiltIn = url === '' || url.startsWith('<anonymous>'); // This looks like a fake anonymous through eval.
return (
<div className={ignored ? styles.IgnoredCallSite : styles.CallSite}>
<div
className={
ignored
? styles.IgnoredCallSite
: isBuiltIn
? styles.BuiltInCallSite
: styles.CallSite
}>
{functionName || virtualFunctionName}
{url !== '' && (
{!isBuiltIn && (
<>
{' @ '}
<span
Expand Down
Loading