Skip to content

[DevTools] Fix host instance highlighting #34661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eps1lon merged 1 commit into from
Oct 1, 2025
Merged

[DevTools] Fix host instance highlighting #34661

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/react-devtools-shared/src/backend/views/Highlighter/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ export default function setupHighlighter(
const nodes = renderer.findHostInstancesForElementID(id);
if (nodes != null) {
for (let i = 0; i < nodes.length; i++) {
const node = nodes[0];
const node = nodes[i];
Copy link
Collaborator Author

@eps1lon eps1lon Sep 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes e.g. the Initial Paint not getting any highlights.

Copy link
Collaborator

@sebmarkbage sebmarkbage Oct 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well I was planning on actually disabling it for the whole document since it's really annoying to flash the whole document every time you hover over a background or first step.

if (node === null) {
continue;
}
Expand Down Expand Up @@ -164,7 +164,7 @@ export default function setupHighlighter(
const nodes = renderer.findHostInstancesForElementID(id);
if (nodes != null) {
for (let i = 0; i < nodes.length; i++) {
const node = nodes[0];
const node = nodes[i];
if (node === null) {
continue;
}
Expand Down
2 changes: 1 addition & 1 deletion packages/react-devtools-shared/src/devtools/views/SuspenseTab/SuspenseBreadcrumbs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ export default function SuspenseBreadcrumbs(): React$Node {
key={id}
className={styles.SuspenseBreadcrumbsListItem}
aria-current={selectedSuspenseID === id}
onPointerEnter={highlightHostInstance.bind(null, id)}
onPointerEnter={highlightHostInstance.bind(null, id, false)}
Copy link
Collaborator Author

@eps1lon eps1lon Sep 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes a crash. Flow.js doesn't have typings for Host Components so this slipped through.

onPointerLeave={clearHighlightHostInstance}>
<button
className={styles.SuspenseBreadcrumbsButton}
Expand Down
Loading