[eslint-plugin-react-hooks][RulesOfHooks] handle React.useEffect in addition to useEffect #34076
+91
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ayc0
commented
Aug 1, 2025
| @@ -48,6 +48,7 @@ | |||
| }, | |||
| "devDependencies": { | |||
| "@babel/eslint-parser": "^7.11.4", | |||
| "babel-plugin-react-compiler": "link:../../compiler/packages/babel-plugin-react-compiler", | |||
There was a problem hiding this comment.
Without this, jest crashes because it can't resolve babel-plugin-react-compiler:
| Before | After |
|---|---|
 |
 |
I used a link because the compiler is in another yarn workspace, so I don't think I can use other protocols like workspace:
And I used a devDependency to avoid having an impact on the published code
Ayc0
commented
Aug 1, 2025
| @@ -129,6 +132,24 @@ function isInsideTryCatch( | |||
| return false; | |||
| } | |||
|
|
|||
| function getNodeWithoutReactNamespace( | |||
Ayc0
commented
Aug 1, 2025
| return node; | ||
| } | ||
|
|
||
| function isUseEffectIdentifier(node: Node): boolean { |
There was a problem hiding this comment.
I could have kept the code inlined, but it makes it a bit more readable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a fix for #34074
How did you test this change?
I added tests in the eslint package, and ran
yarn jest. After adding the new tests, I have this:Changes
link:to theeslint-plugin-react-hookspointing tobabel-plugin-react-compilerotherwise it wouldn't run locallyCallExpression(useEffect(), andMemberExpression(React.useEffect(). To do that, I copied thegetNodeWithoutReactNamespace(fn fromExhaustiveDeps.tstoRulesOfHooks.ts