Fix form state reset when component state is updated #34075
+94
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
React Core Team
|
Comparing: c260b38...9be8342 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
eps1lon
commented
Aug 1, 2025
Comment on lines
-1940
to
-1913
| // This is intentionally set here instead of pushHostContext because | ||
| // pushHostContext gets called before we process the state hook, to avoid | ||
| // a state mismatch in the event that something suspends. |
There was a problem hiding this comment.
I'm not sure I fully understand this comment. If something suspends we pop back up. And the Component we're rendering (here: TransitionAwareHostComponent) should not be able to read the current Context just yet which is what pushing the context before the render would do, right? We can't nest Host Context anyway though. So this seems safe to move the push after the render.
eps1lon
force-pushed
the
sebbie/hostcontextpopper
branch
2 times, most recently
from
b6348c2 to
77dc8cc
Compare
eps1lon
force-pushed
the
sebbie/hostcontextpopper
branch
from
77dc8cc to
9be8342
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternate to #33351 without the regression highlighted in #33351 (comment)
Host context is now modelled like React context in that we set the value in
pushHostContextinstead of duringupdateHostComponent. There was a comment explaining why that shouldn't work but I can't see why it would not work for Host context but normal context.Closes #30368
Closes #33351