Skip to content

[Fizz] Don't outline Boundaries that may contribute to the preamble #34058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions packages/react-dom/src/__tests__/ReactDOMFizzServer-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -10695,4 +10695,40 @@ describe('ReactDOMFizzServer', () => {

expect(getVisibleChildren(container)).toEqual(<div>Success!</div>);
});

it('should always flush the boundaries contributing the preamble regardless of their size', async () => {
const longDescription =
`I need to make this segment somewhat large because it needs to be large enought to be outlined during the initial flush. Setting the progressive chunk size to near zero isn't enough because there is a fixed minimum size that we use to avoid doing the size tracking altogether and this needs to be larger than that at least.
Copy link
Preview

Copilot AI Jul 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a typo in the comment: 'enought' should be 'enough'.

Suggested change
`I need to make this segment somewhat large because it needs to be large enought to be outlined during the initial flush. Setting the progressive chunk size to near zero isn't enough because there is a fixed minimum size that we use to avoid doing the size tracking altogether and this needs to be larger than that at least.
`I need to make this segment somewhat large because it needs to be large enough to be outlined during the initial flush. Setting the progressive chunk size to near zero isn't enough because there is a fixed minimum size that we use to avoid doing the size tracking altogether and this needs to be larger than that at least.

Copilot uses AI. Check for mistakes.


Unfortunately that previous paragraph wasn't quite long enough so I'll continue with some more prose and maybe throw on some repeated additional strings at the end for good measure.

` + 'a'.repeat(500);

const randomTag = Math.random().toString(36).slice(2, 10);

function App() {
return (
<Suspense fallback={randomTag}>
<html lang="en">
<body>
<main>{longDescription}</main>
</body>
</html>
</Suspense>
);
}

let streamedContent = '';
writable.on('data', chunk => (streamedContent += chunk));

await act(() => {
renderToPipeableStream(<App />, {progressiveChunkSize: 100}).pipe(
writable,
);
});

// We don't use the DOM here b/c we execute scripts which hides whether a fallback was shown briefly
// Instead we assert that we never emitted the fallback of the Suspense boundary around the body.
expect(streamedContent).not.toContain(randomTag);
});
});
8 changes: 7 additions & 1 deletion packages/react-server/src/ReactFizzServer.js
Original file line number Diff line number Diff line change
Expand Up @@ -460,7 +460,13 @@ function isEligibleForOutlining(
// For very small boundaries, don't bother producing a fallback for outlining.
// The larger this limit is, the more we can save on preparing fallbacks in case we end up
// outlining.
return boundary.byteSize > 500;
return (
boundary.byteSize > 500 &&
// For boundaries that can possibly contribute to the preamble we don't want to outline
// them regardless of their size since the fallbacks should only be emitted if we've
// errored the boundary.
boundary.contentPreamble === null
);
}

function defaultErrorHandler(error: mixed) {
Expand Down
Loading