-
Notifications
You must be signed in to change notification settings - Fork 49k
[Fiber] Deprecate "Throw a Promise" technique #34032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sebmarkbage
wants to merge
1
commit into
facebook:main
Choose a base branch
from
sebmarkbage:deprecatethrowapromise
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+34
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comparing: 9be531c...4c786b6 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
81d1fcb
to
a299ba0
Compare
poteto
added a commit
that referenced
this pull request
Jul 29, 2025
Follow up to #34032. The linter now ensures that `use` cannot be used within try/catch.
poteto
added a commit
that referenced
this pull request
Jul 29, 2025
Follow up to #34032. The linter now ensures that `use` cannot be used within try/catch.
poteto
added a commit
that referenced
this pull request
Jul 29, 2025
Follow up to #34032. The linter now ensures that `use` cannot be used within try/catch.
a299ba0
to
4c786b6
Compare
poteto
added a commit
that referenced
this pull request
Jul 29, 2025
Follow up to #34032. The linter now ensures that `use` cannot be used within try/catch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been replaced by
React.use(promise)
which in turn should be used unconditionally if data is depended upon.The "throw a Promise" technique has many issues.
use()
syntax ensures that the lint rule warns you if you try/catch it or place it in a function that's not a Hook or Component.use()
model can support just plain uncached Promises as well and potentially just plain async functions on the client.lazy
anduse(promise)
are implemented similarly to share as much code as possible but it would be a lot simpler if they could just suspend in place where those APIs are implemented instead of in the core of the work loop.