[Flight] Remove superfluous whitespace when console method is called with non-strings #33953
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
React Core Team
sebmarkbage
reviewed
Jul 21, 2025
| offset, | ||
| 1, | ||
| badgeFormat + newArgs[offset], | ||
| badgeFormat + ' ' + newArgs[offset], |
Collaborator
There was a problem hiding this comment.
You don't have the equivalent of this in ReactServerConsoleConfig. If you add it, you have to remove it when unbadging.
Collaborator
Author
There was a problem hiding this comment.
eps1lon
force-pushed
the
sebbie/console-spacing
branch
from
59cff76 to
7e7c8f2
Compare
eps1lon
force-pushed
the
sebbie/console-spacing
branch
from
7e7c8f2 to
25f8893
Compare
sebmarkbage
approved these changes
Jul 22, 2025
github-actions bot
pushed a commit
to code/lib-react
that referenced
this pull request
Jul 28, 2025
…with non-strings (facebook#33953) DiffTrain build for [f6fb1a0](facebook@f6fb1a0)
github-actions bot
pushed a commit
to code/lib-react
that referenced
this pull request
Jul 28, 2025
…with non-strings (facebook#33953) DiffTrain build for [f6fb1a0](facebook@f6fb1a0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Runtimes will put spacing between console arguments by themselves (checked with Chrome, Firefox, Safari and Node.js). React only needs to add spacing if it logs the badge and the original template string as a single argument.
Before:
After: