Skip to content

Conversation

@sebmarkbage
Copy link
Collaborator

We typically treat an empty message as closing the debug channel stream but for the Noop renderer we don't use an intermediate stream but just pass the message through.

if (message === '') {
writer.close();

For that simple case we should just treat it as a close without an intermediate stream.

@sebmarkbage sebmarkbage requested a review from unstubbable July 10, 2025 19:39
@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Jul 10, 2025
@react-sizebot
Copy link

Comparing: 463b808...e843a81

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 530.70 kB 530.70 kB = 93.70 kB 93.70 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 655.25 kB 655.25 kB = 115.40 kB 115.40 kB
facebook-www/ReactDOM-prod.classic.js = 675.13 kB 675.13 kB = 118.75 kB 118.75 kB
facebook-www/ReactDOM-prod.modern.js = 665.56 kB 665.56 kB = 117.12 kB 117.11 kB
oss-stable-semver/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.production.js +12.04% 2,024.42 kB 2,268.19 kB +17.09% 290.14 kB 339.71 kB
oss-stable/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.production.js +12.04% 2,024.42 kB 2,268.19 kB +17.09% 290.14 kB 339.71 kB
oss-experimental/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.production.js +12.04% 2,024.60 kB 2,268.37 kB +17.09% 290.16 kB 339.74 kB
oss-stable-semver/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js +12.01% 2,028.87 kB 2,272.64 kB +17.02% 291.11 kB 340.67 kB
oss-stable/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js +12.01% 2,028.87 kB 2,272.64 kB +17.02% 291.11 kB 340.67 kB
oss-experimental/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js +12.01% 2,029.05 kB 2,272.81 kB +17.02% 291.14 kB 340.69 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable-semver/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.production.js +12.04% 2,024.42 kB 2,268.19 kB +17.09% 290.14 kB 339.71 kB
oss-stable/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.production.js +12.04% 2,024.42 kB 2,268.19 kB +17.09% 290.14 kB 339.71 kB
oss-experimental/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.production.js +12.04% 2,024.60 kB 2,268.37 kB +17.09% 290.16 kB 339.74 kB
oss-stable-semver/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js +12.01% 2,028.87 kB 2,272.64 kB +17.02% 291.11 kB 340.67 kB
oss-stable/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js +12.01% 2,028.87 kB 2,272.64 kB +17.02% 291.11 kB 340.67 kB
oss-experimental/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js +12.01% 2,029.05 kB 2,272.81 kB +17.02% 291.14 kB 340.69 kB

Generated by 🚫 dangerJS against e843a81

@sebmarkbage sebmarkbage merged commit eed2560 into facebook:main Jul 10, 2025
474 of 475 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants