Skip to content

[Flight] Bypass caches in Flight fixture if requested #33445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 6, 2025

Conversation

unstubbable
Copy link
Collaborator

When the "Disable cache" checkbox is checked in the dev tools, we should bypass the caching of the 3rd-party component in the Flight fixture. This allows us to quickly compare the different output (with and without caching) in React's custom performance tracks.

When the "Disable cache" checkbox is checked in the dev tools, we should
bypass the caching of the 3rd-party component in the Flight fixture.
This allows us to quickly compare the different output (with and without
caching) in React's custom performance tracks.
@unstubbable unstubbable requested a review from sebmarkbage June 5, 2025 15:38
@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Jun 5, 2025
@react-sizebot
Copy link

react-sizebot commented Jun 5, 2025

Comparing: b4477d3...c586560

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 530.07 kB 530.07 kB = 93.57 kB 93.57 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 651.16 kB 651.16 kB = 114.70 kB 114.70 kB
facebook-www/ReactDOM-prod.classic.js = 676.11 kB 676.11 kB = 118.97 kB 118.97 kB
facebook-www/ReactDOM-prod.modern.js = 666.39 kB 666.39 kB = 117.36 kB 117.36 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against c586560

@unstubbable unstubbable force-pushed the flight-fixture-bypass-cache branch from 7f912d1 to c586560 Compare June 5, 2025 16:16
Copy link

@Hardanish-Singh Hardanish-Singh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants