Skip to content

[ci] Scope permissions for all workflows #32704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 21, 2025
Merged

[ci] Scope permissions for all workflows #32704

merged 2 commits into from
Mar 21, 2025

Conversation

poteto
Copy link
Member

@poteto poteto commented Mar 21, 2025

This PR restricts permissions on all workflows for the github.token to none by default. Where needed, specific permissions are added only in the job that requires them.

Stack created with Sapling. Best reviewed with ReviewStack.

poteto added 2 commits March 21, 2025 12:28
By default the github token is used with write-all permissions. Let's scope it down to just what we need.

https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#permissions
This PR restricts permissions on all workflows for the `github.token` to none by default. Where needed, specific permissions are added only in the job that requires them.
@react-sizebot
Copy link

Comparing: e1e7407...5b72271

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB +0.05% 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 517.29 kB 517.29 kB = 92.26 kB 92.26 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 617.68 kB 617.68 kB = 109.55 kB 109.55 kB
facebook-www/ReactDOM-prod.classic.js = 653.74 kB 653.74 kB = 115.19 kB 115.20 kB
facebook-www/ReactDOM-prod.modern.js = 644.02 kB 644.02 kB = 113.61 kB 113.61 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 5b72271

@poteto poteto merged commit ab693a9 into main Mar 21, 2025
256 checks passed
@poteto poteto deleted the pr32704 branch March 21, 2025 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants