Skip to content

[flags] make enableComponentPerformanceTrack dynamic #32359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 6, 2025
Merged

[flags] make enableComponentPerformanceTrack dynamic #32359

merged 1 commit into from
Mar 6, 2025

Conversation

rickhanlonii
Copy link
Member

No description provided.

@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Feb 12, 2025
@react-sizebot
Copy link

react-sizebot commented Feb 12, 2025 •
edited
Loading

Comparing: 9e9b54d...c05755b

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 518.54 kB 518.54 kB = 92.45 kB 92.45 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 589.31 kB 589.31 kB = 104.91 kB 104.91 kB
facebook-www/ReactDOM-prod.classic.js = 642.76 kB 642.76 kB = 113.01 kB 113.01 kB
facebook-www/ReactDOM-prod.modern.js = 633.08 kB 633.08 kB = 111.44 kB 111.44 kB
facebook-www/ReactART-dev.modern.js +6.43% 656.78 kB 698.98 kB +5.31% 103.79 kB 109.30 kB
facebook-www/ReactART-dev.classic.js +6.33% 666.27 kB 708.48 kB +5.21% 105.63 kB 111.14 kB
facebook-www/ReactDOM-profiling.modern.js +5.63% 660.47 kB 697.65 kB +4.66% 115.34 kB 120.72 kB
facebook-www/ReactReconciler-dev.modern.js +5.54% 762.76 kB 805.01 kB +4.61% 119.40 kB 124.90 kB
facebook-www/ReactReconciler-dev.classic.js +5.47% 771.96 kB 814.22 kB +4.57% 121.04 kB 126.57 kB
facebook-www/ReactDOM-profiling.classic.js +5.30% 670.20 kB 705.69 kB +4.37% 116.94 kB 122.05 kB
facebook-www/ReactDOM-dev.modern.js +3.83% 1,113.90 kB 1,156.53 kB +3.05% 185.64 kB 191.30 kB
facebook-www/ReactDOM-dev.classic.js +3.80% 1,123.04 kB 1,165.67 kB +3.01% 187.37 kB 193.01 kB
facebook-www/ReactDOMTesting-dev.modern.js +3.77% 1,130.81 kB 1,173.43 kB +2.99% 189.50 kB 195.15 kB
facebook-www/ReactDOMTesting-dev.classic.js +3.74% 1,139.95 kB 1,182.57 kB +2.98% 191.22 kB 196.91 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
facebook-www/ReactART-dev.modern.js +6.43% 656.78 kB 698.98 kB +5.31% 103.79 kB 109.30 kB
facebook-www/ReactART-dev.classic.js +6.33% 666.27 kB 708.48 kB +5.21% 105.63 kB 111.14 kB
facebook-www/ReactDOM-profiling.modern.js +5.63% 660.47 kB 697.65 kB +4.66% 115.34 kB 120.72 kB
facebook-www/ReactReconciler-dev.modern.js +5.54% 762.76 kB 805.01 kB +4.61% 119.40 kB 124.90 kB
facebook-www/ReactReconciler-dev.classic.js +5.47% 771.96 kB 814.22 kB +4.57% 121.04 kB 126.57 kB
facebook-www/ReactDOM-profiling.classic.js +5.30% 670.20 kB 705.69 kB +4.37% 116.94 kB 122.05 kB
facebook-www/ReactDOM-dev.modern.js +3.83% 1,113.90 kB 1,156.53 kB +3.05% 185.64 kB 191.30 kB
facebook-www/ReactDOM-dev.classic.js +3.80% 1,123.04 kB 1,165.67 kB +3.01% 187.37 kB 193.01 kB
facebook-www/ReactDOMTesting-dev.modern.js +3.77% 1,130.81 kB 1,173.43 kB +2.99% 189.50 kB 195.15 kB
facebook-www/ReactDOMTesting-dev.classic.js +3.74% 1,139.95 kB 1,182.57 kB +2.98% 191.22 kB 196.91 kB

Generated by 🚫 dangerJS against e6f46db

@rickhanlonii rickhanlonii force-pushed the rh/component-profiler branch from 703de00 to e6f46db Compare March 6, 2025 18:54
@rickhanlonii rickhanlonii marked this pull request as ready for review March 6, 2025 18:54
@rickhanlonii rickhanlonii merged commit f9d7808 into facebook:main Mar 6, 2025
196 checks passed
@rickhanlonii rickhanlonii deleted the rh/component-profiler branch March 6, 2025 19:00
github-actions bot pushed a commit that referenced this pull request Mar 6, 2025
@rickhanlonii
[flags] make enableComponentPerformanceTrack dynamic (#32359)
e4426d0 
DiffTrain build for [f9d7808](f9d7808)
This was referenced Mar 7, 2025
Closed
Closed
Merged
huozhi pushed a commit to vercel/next.js that referenced this pull request Mar 11, 2025
@vercel-release-bot
Upgrade React from 029e8bd6-20250306 to 0ca3deeb-20250311 (#76989)
808934a 
[diff
facebook/react@029e8bd6...0ca3deeb](facebook/react@029e8bd...0ca3dee)

<details>
<summary>React upstream changes</summary>

- facebook/react#32569
- facebook/react#32567
- facebook/react#32549
- facebook/react#32545
- facebook/react#32566
- facebook/react#32551
- facebook/react#32550
- facebook/react#32528
- facebook/react#32359
- facebook/react#32536
- facebook/react#32539

</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kassens kassens kassens approved these changes

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rickhanlonii @react-sizebot @kassens @facebook-github-bot