Drop processAttributeNameAndPrefix and invalid attribute name escaping #3047
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks good. |
syranide
added a commit
that referenced
this pull request
Feb 5, 2015
Drop processAttributeNameAndPrefix and invalid attribute name escaping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #1599 (extraneous changes)
Attribute names cannot be escaped, it's invalid. The current implementation is technically equivalent to dropping invalid attribute names (except it ends up in the markup)... buuuut, invalid attribute names cannot be encountered here at current due to our property whitelist (which applies to data/aria as well), so any logic for dropping invalid attribute names is unnecessary at this point.
cc @yungsters